spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] viirya commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
Date Fri, 21 Feb 2020 05:25:04 GMT
viirya commented on a change in pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils
URL: https://github.com/apache/spark/pull/27617#discussion_r382403027
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
 ##########
 @@ -321,13 +315,13 @@ object DateTimeUtils {
     }
   }
 
-  def instantToMicros(instant: Instant): Long = {
+  def instantToMicros(instant: Instant): SQLTimestamp = {
 
 Review comment:
   +1 I remember few times I need to go back to check what it means.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message