spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL] Review and fix issues in SQL API docs
Date Thu, 20 Feb 2020 11:04:04 GMT
cloud-fan commented on a change in pull request #27560: [SPARK-30809][SQL] Review and fix issues
in SQL API docs
URL: https://github.com/apache/spark/pull/27560#discussion_r381930412
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
 ##########
 @@ -488,6 +488,8 @@ object DataType {
 
 /**
  * Jackson serializer for [[DataType]]. Internally this delegates to json4s based serialization.
+ *
+ * @since 3.0.0
  */
 class DataTypeJsonSerializer extends JsonSerializer[DataType] {
 
 Review comment:
   classes in the catalyst package are treated as private classes and we don't really need
to add the `private[sql]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message