spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
Date Wed, 19 Feb 2020 02:08:46 GMT
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested
bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r381040836
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -1797,11 +1797,11 @@ SIMPLE_COMMENT
     ;
 
 BRACKETED_EMPTY_COMMENT
-    : '/**/' -> channel(HIDDEN)
+    : '/*' BRACKETED_EMPTY_COMMENT* '*/' -> channel(HIDDEN)
     ;
 
 BRACKETED_COMMENT
-    : '/*' ~[+] .*? '*/' -> channel(HIDDEN)
+    : '/*' (BRACKETED_COMMENT .*? | ~[+] (BRACKETED_COMMENT|.)*?)*? '*/' -> channel(HIDDEN)
 
 Review comment:
   It can't pass `PlanParserSuite`.
   ```
    - SPARK-20854: multiple hints *** FAILED *** (6 milliseconds)
   [info]   == FAIL: Plans do not match ===
   [info]   !'Project [*]                 'UnresolvedHint HINT1, ['a, 1]
   [info]   !+- 'UnresolvedRelation [t]   +- 'UnresolvedHint hint2, ['b, 2]
   [info]   !                                +- 'Project [*]
   [info]   !                                   +- 'UnresolvedRelation [t] (PlanTest.scala:147)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message