spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean config name to comply with new config naming policy
Date Fri, 14 Feb 2020 12:30:09 GMT
cloud-fan commented on a change in pull request #27563: [SPARK-30812][SQL][CORE] Revise boolean
config name to comply with new config naming policy
URL: https://github.com/apache/spark/pull/27563#discussion_r379405867
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -425,7 +425,7 @@ object SQLConf {
     .createWithDefault(true)
 
   val ADAPTIVE_EXECUTION_SKEWED_JOIN_ENABLED =
-    buildConf("spark.sql.adaptive.optimizeSkewedJoin.enabled")
+    buildConf("spark.sql.adaptive.optimizeSkewedJoin")
 
 Review comment:
   `optimizeSkewedJoin` is used as a namespace and has sub-configs. how about `spark.sql.adaptive.skewedJoinOptimization.enabled`?
   
   cc @JkSelf @maryannxue 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message