spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options
Date Wed, 05 Feb 2020 01:13:14 GMT
HyukjinKwon commented on a change in pull request #27459: [SPARK-30510][SQL][DOCS] Publicly
document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r375012035
 
 

 ##########
 File path: sql/gen-sql-markdown.py
 ##########
 @@ -47,6 +53,18 @@ def _list_function_infos(jvm):
     return sorted(infos, key=lambda i: i.name)
 
 
+def _list_sql_configs(jvm):
+    sql_configs = [
+        SQLConfEntry(
+            name=_sql_config._1(),
+            default=_sql_config._2(),
 
 Review comment:
   I vaguely suspect it's because of some default values like `Option`. I will take a close
look within few days.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message