spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on a change in pull request #27456: [SPARK-25040][SQL][FOLLOWUP] Add legacy config for allowing empty strings for certain types in json parser
Date Tue, 04 Feb 2020 19:41:02 GMT
MaxGekk commented on a change in pull request #27456: [SPARK-25040][SQL][FOLLOWUP] Add legacy
config for allowing empty strings for certain types in json parser
URL: https://github.com/apache/spark/pull/27456#discussion_r374882360
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
 ##########
 @@ -307,6 +308,8 @@ class JacksonParser(
     }
   }
 
+  private lazy val allowEmptyString = SQLConf.get.getConf(SQLConf.LEGACY_ALLOW_EMPTY_STRING_IN_JSON)
 
 Review comment:
   Yeh, but lazy val consumes memory as well even if it is not touched. Need to maintain an
internal flag to track that the `val` was touched or not. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message