From reviews-return-1025290-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Jan 29 05:00:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40F55180658 for ; Wed, 29 Jan 2020 06:00:54 +0100 (CET) Received: (qmail 42943 invoked by uid 500); 29 Jan 2020 05:00:53 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 42931 invoked by uid 99); 29 Jan 2020 05:00:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jan 2020 05:00:53 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] dongjoon-hyun commented on issue #27379: [SPARK-23435][2.4][SPARKR][TESTS] Update testthat to >= 2.0.0 Message-ID: <158027405333.22055.17034655558254342097.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 29 Jan 2020 05:00:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dongjoon-hyun commented on issue #27379: [SPARK-23435][2.4][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27379#issuecomment-579593312 @HyukjinKwon . Is this urgent enough to ignore the community LGTM rule? For me, this is not an HOTFIX or urgent PR. Also, @shaneknapp told us that Jenkins upgrade will not happen until next week. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org