From reviews-return-1012187-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Jan 13 20:26:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D933180665 for ; Mon, 13 Jan 2020 21:26:30 +0100 (CET) Received: (qmail 28742 invoked by uid 500); 13 Jan 2020 20:26:30 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 28730 invoked by uid 99); 13 Jan 2020 20:26:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2020 20:26:30 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] gengliangwang commented on a change in pull request #27194: [SPARK-30505][DOCS] Deprecate Avro option `ignoreExtension` in sql-data-sources-avro.md Message-ID: <157894719039.27850.5612349145617761810.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 13 Jan 2020 20:26:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit gengliangwang commented on a change in pull request #27194: [SPARK-30505][DOCS] Deprecate Avro option `ignoreExtension` in sql-data-sources-avro.md URL: https://github.com/apache/spark/pull/27194#discussion_r366010895 ########## File path: docs/sql-data-sources-avro.md ########## @@ -230,7 +230,7 @@ Data source options of Avro can be set via: ignoreExtension true - The option controls ignoring of files without .avro extensions in read.
If the option is enabled, all files (with and without .avro extension) are loaded. + The option controls ignoring of files without .avro extensions in read.
If the option is enabled, all files (with and without .avro extension) are loaded.
The option has been already deprecated, and it will be removed in the future releases. Please use the general data source option pathGlobFilter for filtering file names. Review comment: Thanks for the work. Could you also create a doc entry for the option `pathGlobFilter` and link to it here in this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org