spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR opened a new pull request #27365: [MINOR][SQL] Convert CRLF into LF in source files
Date Sun, 26 Jan 2020 13:24:23 GMT
HeartSaVioR opened a new pull request #27365: [MINOR][SQL] Convert CRLF into LF in source files
URL: https://github.com/apache/spark/pull/27365
 
 
   ### What changes were proposed in this pull request?
   
   This patch converts CR/LF into LF in 3 source files, which most files are only using LF.
   
   ### Why are the changes needed?
   
   The majority of source code files are using LF and only three files are CR/LF. While using
IDE would let us don't bother with the difference, it still has a chance to make unnecessary
diff if the file is modified with the editor which doesn't handle it automatically.
   
   ### Does this PR introduce any user-facing change?
   
   No
   
   ### How was this patch tested?
   
   ```
   grep -IUrl --color "^M" . | grep "\.java\|\.scala\|\.xml\|\.py\|\.R" | grep -v "/target/"
| grep -v "/build/" | grep -v "/dist/" | grep -v "dependency-reduced-pom.xml" | grep -v ".pyc"
   ```
   
   Before the patch, the result is:
   
   ```
   ./sql/core/src/main/java/org/apache/spark/sql/execution/columnar/ColumnDictionary.java
   ./sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala
   ./sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
   ```
   
   and after the patch, the result is None.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message