spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #27311: [SPARK-27996][WEBUI] Send HTTP redirect using the correct protocol when Spark History server is deployed behind the reverse proxy
Date Sat, 25 Jan 2020 01:09:45 GMT
dongjoon-hyun commented on a change in pull request #27311: [SPARK-27996][WEBUI] Send HTTP
redirect using the correct protocol when Spark History server is deployed behind the reverse
proxy
URL: https://github.com/apache/spark/pull/27311#discussion_r370901620
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/deploy/history/ApplicationCacheSuite.scala
 ##########
 @@ -370,7 +370,9 @@ class ApplicationCacheSuite extends SparkFunSuite with Logging with MockitoSugar
 
     val request = mock[HttpServletRequest]
     when(request.getMethod()).thenReturn("GET")
-    when(request.getRequestURI()).thenReturn("http://localhost:18080/history/local-123/jobs/job/")
+    when(request.getRequestURI()).thenReturn("/history/local-123/jobs/job/")
 
 Review comment:
   Oh, was it? Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message