spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] tgravescs commented on issue #27233: [SPARK-29701][SQL] Correct behaviours of group analytical queries when empty input given
Date Fri, 24 Jan 2020 15:53:01 GMT
tgravescs commented on issue #27233: [SPARK-29701][SQL] Correct behaviours of group analytical
queries when empty input given
URL: https://github.com/apache/spark/pull/27233#issuecomment-578187736
 
 
   I think its the definition of correctness. To me correctness means you get the wrong data
back out.  You can obviously argue it either way.  I think here this is a compatibility with
the sql standard and a very corner case at that. You either get no rows or count 0, no rows
implies count of 0 to me, the 0 to me seems counter intuitive anyway.  I get that its a Sql
standard, but obviously other SQL engines also have this issue which is why I would say its
a corner case to being fully sql compliant.  If we were returning a number that was just purely
wrong, I would be in the camp of the correctness issue.    If there are other people that
disagree then it obviously needs discussion, if someone can give me a concrete example that
this caused them $$ lost that might change my mind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message