spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #27349: [SPARK-30617][SQL] Stop check values of spark.sql.catalogImplementation to improve expansibility
Date Fri, 24 Jan 2020 03:53:29 GMT
dongjoon-hyun commented on a change in pull request #27349: [SPARK-30617][SQL] Stop check values
of spark.sql.catalogImplementation to improve expansibility
URL: https://github.com/apache/spark/pull/27349#discussion_r370464545
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
 ##########
 @@ -36,9 +36,13 @@ object StaticSQLConf {
     .createWithDefault(Utils.resolveURI("spark-warehouse").toString)
 
   val CATALOG_IMPLEMENTATION = buildStaticConf("spark.sql.catalogImplementation")
+    .doc("Spark built-in implementation is in-memory and hive," +
 
 Review comment:
   nit. `,"` -> `, "`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message