spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] jiangxb1987 commented on a change in pull request #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated when updateBlockInfo returns false
Date Wed, 22 Jan 2020 23:24:29 GMT
jiangxb1987 commented on a change in pull request #27306: [SPARK-30594][CORE] Do not post SparkListenerBlockUpdated
when updateBlockInfo returns false
URL: https://github.com/apache/spark/pull/27306#discussion_r369856728
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
 ##########
 @@ -98,8 +98,15 @@ class BlockManagerMasterEndpoint(
 
     case _updateBlockInfo @
         UpdateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize, size) =>
-      context.reply(updateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize,
size))
-      listenerBus.post(SparkListenerBlockUpdated(BlockUpdatedInfo(_updateBlockInfo)))
+      val succeed = updateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize,
size)
 
 Review comment:
   nit: `succeed` -> `result`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message