spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] hvanhovell commented on a change in pull request #27267: [SPARK-30556][SQL] Copy sparkContext.localproperties to child thread inSubqueryExec.executionContext
Date Tue, 21 Jan 2020 21:28:47 GMT
hvanhovell commented on a change in pull request #27267: [SPARK-30556][SQL] Copy sparkContext.localproperties
to child thread inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r369252360
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
 ##########
 @@ -164,4 +166,19 @@ object SQLExecution {
       }
     }
   }
+
+  /**
+   * Wrap passed function to ensure necessary thread-local variables like
+   * SparkContext local properties are forwarded to execution thread
+   */
+  def withThreadLocalCaptured[T](sparkSession: SparkSession, exec: ExecutionContext)(
+    body: => T): Future[T] = {
+    val activeSession = sparkSession
+    val localProps = Utils.cloneProperties(sparkSession.sparkContext.getLocalProperties)
+    Future {
+      SparkSession.setActiveSession(activeSession)
 
 Review comment:
   Can you please unset/restore both of them to their old state?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message