spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL] Migrate ALTER TABLE commands to the new framework
Date Mon, 20 Jan 2020 06:38:47 GMT
cloud-fan commented on a change in pull request #27243: [SPARK-30535][SQL] Migrate ALTER TABLE
commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r368387681
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ##########
 @@ -420,63 +425,71 @@ trait CheckAnalysis extends PredicateHelper {
             }
 
           case alter: AlterTable if alter.childrenResolved =>
 
 Review comment:
   BTW we can't hit v1 table here right? We should have converted alter table command to v1
if the table is v1, before we reach here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message