spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Ngone51 commented on issue #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal
Date Fri, 17 Jan 2020 05:33:58 GMT
Ngone51 commented on issue #26881: [SPARK-30252][SQL] Disallow negative scale of Decimal
URL: https://github.com/apache/spark/pull/26881#issuecomment-575472015
 
 
   I reverted the check for max precision added in `set(decimal: BigDecimal)` because it can
break overflow check. That is, Spark is allowed to create a decimal which has precision larger
than 38 and then overflow check will decide to return null or throw exception which depends
on ansi. So, if we try to add check early in the `set`, then we'll get exception early too
before we check overflow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message