spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] sandeep-katta commented on a change in pull request #27021: [SPARK-30362][Core] Update InputMetrics in DataSourceRDD
Date Fri, 17 Jan 2020 04:40:14 GMT
sandeep-katta commented on a change in pull request #27021: [SPARK-30362][Core] Update InputMetrics
in DataSourceRDD
URL: https://github.com/apache/spark/pull/27021#discussion_r367766603
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
 ##########
 @@ -56,6 +58,15 @@ class DataSourceRDD(
     context.addTaskCompletionListener[Unit](_ => reader.close())
     val iter = new Iterator[Any] {
       private[this] var valuePrepared = false
+      private val inputMetrics = context.taskMetrics().inputMetrics
+      private val existingBytesRead = inputMetrics.bytesRead
 
 Review comment:
   if we update only "recordsRead". In the UI "Input Size/Records" column will look like "0/
10". Is this okay ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message