spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HeartSaVioR commented on a change in pull request #26201: [SPARK-29543][SS][UI] Init structured streaming ui
Date Tue, 14 Jan 2020 03:23:57 GMT
HeartSaVioR commented on a change in pull request #26201: [SPARK-29543][SS][UI] Init structured
streaming ui
URL: https://github.com/apache/spark/pull/26201#discussion_r366137144
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatusListener.scala
 ##########
 @@ -45,13 +50,15 @@ class StreamingQueryStatusListener(sqlConf: SQLConf) extends StreamingQueryListe
 
   override def onQueryStarted(event: StreamingQueryListener.QueryStartedEvent): Unit = {
     activeQueryStatus.putIfAbsent(event.runId,
-      new StreamingQueryUIData(event.name, event.id, event.runId))
+      new StreamingQueryUIData(event.name, event.id, event.runId, event.submitTime))
   }
 
   override def onQueryProgress(event: StreamingQueryListener.QueryProgressEvent): Unit =
{
+    val batchTimestamp = timestampFormat.parse(event.progress.timestamp).getTime
     val queryStatus = activeQueryStatus.getOrDefault(
       event.progress.runId,
-      new StreamingQueryUIData(event.progress.name, event.progress.id, event.progress.runId))
+      new StreamingQueryUIData(event.progress.name, event.progress.id, event.progress.runId,
 
 Review comment:
   My intention was not to touch event but be conditional if the UI data is created with onQueryProgress,
but the change looks even better to me. I guess adding the field in QueryStartedEvent is OK,
as it's marked as Evolving.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message