spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] turboFei commented on a change in pull request #27150: SPARK-30471: Fix issue when comparing String and IntegerType
Date Fri, 10 Jan 2020 10:35:47 GMT
turboFei commented on a change in pull request #27150: SPARK-30471: Fix issue when comparing
String and IntegerType
URL: https://github.com/apache/spark/pull/27150#discussion_r365171090
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ##########
 @@ -142,6 +142,8 @@ object TypeCoercion {
     case (n: DecimalType, s: StringType) => Some(DoubleType)
     case (s: StringType, n: DecimalType) => Some(DoubleType)
 
+    case (l: StringType, r: IntegerType) => Some(DoubleType)
 
 Review comment:
   ![image](https://user-images.githubusercontent.com/6757692/72146648-d9021900-33d7-11ea-8d92-0e5137619f35.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message