spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] Eric5553 commented on a change in pull request #26977: [SPARK-30326][SQL] Raise exception if analyzer exceed max iterations
Date Wed, 08 Jan 2020 09:21:15 GMT
Eric5553 commented on a change in pull request #26977: [SPARK-30326][SQL] Raise exception if
analyzer exceed max iterations
URL: https://github.com/apache/spark/pull/26977#discussion_r364131627
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
 ##########
 @@ -47,6 +47,19 @@ trait AnalysisTest extends PlanTest {
     }
   }
 
+  protected def makeAnalyzerWithConf(conf: SQLConf): Analyzer = {
 
 Review comment:
   @maropu I moved the helper method in commit ab82c4136144e3bd2b00ce94e87927f7e9eb93f9

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message