spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] MaxGekk commented on a change in pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter" as a general option for all file sources
Date Tue, 07 Jan 2020 19:18:38 GMT
MaxGekk commented on a change in pull request #24518: [SPARK-27627][SQL] Make option "pathGlobFilter"
as a general option for all file sources
URL: https://github.com/apache/spark/pull/24518#discussion_r363907552
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
 ##########
 @@ -59,14 +59,15 @@ class AvroOptions(
    * If the option is not set, the Hadoop's config `avro.mapred.ignore.inputs.without.extension`
    * is taken into account. If the former one is not set too, file extensions are ignored.
    */
+  @deprecated("Use the general data source option pathGlobFilter for filtering file names",
"3.0")
 
 Review comment:
   I am wondering whom is this deprecation warning to? Spark users don't use `ignoreExtension`
directly. I do think we should print a warning when we read & detect that `AvroFileFormat.IgnoreFilesWithoutExtensionProperty`
and/or `AvroOptions.ignoreExtensionKey` are set otherwise users will never see the deprecation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message