spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] uncleGen commented on a change in pull request #26201: [SPARK-29543][SS][UI] Init structured streaming ui
Date Tue, 07 Jan 2020 08:37:51 GMT
uncleGen commented on a change in pull request #26201: [SPARK-29543][SS][UI] Init structured
streaming ui
URL: https://github.com/apache/spark/pull/26201#discussion_r363640024
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
 ##########
 @@ -393,7 +392,7 @@ class StreamingQueryManager private[sql] (sparkSession: SparkSession)
extends Lo
   private def unregisterTerminatedStream(terminatedQueryId: UUID): Unit = {
     activeQueriesLock.synchronized {
       // remove from shared state only if the streaming query manager also matches
-      sparkSession.sharedState.activeStreamingQueries.remove(terminatedQueryId, this)
+      sparkSession.sharedState.streamQueryStore.terminate(terminatedQueryId)
 
 Review comment:
   `StreamQueryStore` will be removed after we use StreamingQueryListener to track UI data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message