From reviews-return-997481-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Dec 25 04:14:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8DB1F18065E for ; Wed, 25 Dec 2019 05:14:09 +0100 (CET) Received: (qmail 65879 invoked by uid 500); 25 Dec 2019 04:14:08 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 65867 invoked by uid 99); 25 Dec 2019 04:14:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Dec 2019 04:14:08 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] seayoun commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever Message-ID: <157724724818.16170.10081115380913010910.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 25 Dec 2019 04:14:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit seayoun commented on issue #26975: [SPARK-30325][CORE] Stage retry and executor crash cause app hung up forever URL: https://github.com/apache/spark/pull/26975#issuecomment-568834508 @cloud-fan PTAL, I have a deep think and remove the kill logic, and in `handleSuccessfulTask` I think we needn't handle this case, it can overwrite the shuffle meta info, beause if the executor keeping the partition shuffle data was lost, we can `Resubmit` this partition in current stage instead of reschedule the partition in the next stage by `FetchFailedException` cc @HyukjinKwon @jiangxb1987 @Ngone51 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org