From reviews-return-981502-archive-asf-public=cust-asf.ponee.io@spark.apache.org Mon Dec 2 03:10:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40AB718061A for ; Mon, 2 Dec 2019 04:10:10 +0100 (CET) Received: (qmail 75147 invoked by uid 500); 2 Dec 2019 03:10:09 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 75135 invoked by uid 99); 2 Dec 2019 03:10:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2019 03:10:09 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] xy2953396112 commented on a change in pull request #26693: [MINOR][SS] Note that writer should not be closed in RateStreamMicroBatchStream.serialize Message-ID: <157525620938.21599.10326650896134016390.gitbox@gitbox.apache.org> Date: Mon, 02 Dec 2019 03:10:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit xy2953396112 commented on a change in pull request #26693: [MINOR][SS] Note that writer should not be closed in RateStreamMicroBatchStream.serialize URL: https://github.com/apache/spark/pull/26693#discussion_r352405272 ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchStream.scala ########## @@ -62,6 +62,7 @@ class RateStreamMicroBatchStream( val metadataLog = new HDFSMetadataLog[LongOffset](session.get, checkpointLocation) { + // Writer should not close the given stream when overriding methods. Review comment: my mistake... Please review again.Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org