spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] cloud-fan commented on a change in pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive query execution by default
Date Mon, 30 Dec 2019 17:51:18 GMT
cloud-fan commented on a change in pull request #26813: [SPARK-30188][SQL][WIP] Enable adaptive
query execution by default
URL: https://github.com/apache/spark/pull/26813#discussion_r362052848
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/util/DataFrameCallbackSuite.scala
 ##########
 @@ -89,38 +90,42 @@ class DataFrameCallbackSuite extends QueryTest with SharedSparkSession
{
   }
 
   test("get numRows metrics by callback") {
-    val metrics = ArrayBuffer.empty[Long]
-    val listener = new QueryExecutionListener {
-      // Only test successful case here, so no need to implement `onFailure`
-      override def onFailure(funcName: String, qe: QueryExecution, error: Throwable): Unit
= {}
-
-      override def onSuccess(funcName: String, qe: QueryExecution, duration: Long): Unit
= {
-        val metric = qe.executedPlan match {
-          case w: WholeStageCodegenExec => w.child.longMetric("numOutputRows")
-          case other => other.longMetric("numOutputRows")
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false") {
+      // with AQE on, the WholeStageCodegen rule is applied when running QueryStageExec.
 
 Review comment:
   for this test, shall we strip the `AdaptiveSparkPlan` and get `WholeStageCodegenExec`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message