spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #27046: [SPARK-29348][SQL][FOLLOWUP] Add example of batch query for observable metrics
Date Mon, 30 Dec 2019 09:25:44 GMT
HyukjinKwon commented on a change in pull request #27046: [SPARK-29348][SQL][FOLLOWUP] Add
example of batch query for observable metrics
URL: https://github.com/apache/spark/pull/27046#discussion_r361936639
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
 ##########
 @@ -110,7 +112,7 @@ class QueryExecution(
     executedPlan.execute(), sparkSession.sessionState.conf)
 
   /** Get the metrics observed during the execution of the query plan. */
-  def observedMetrics: Map[String, Row] = CollectMetricsExec.collect(executedPlan)
+  def observedMetrics: java.util.Map[String, Row] = CollectMetricsExec.collect(executedPlan).asJava
 
 Review comment:
   FYI @hvanhovell as I believe you're already using this API; this changes the method signature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message