spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #26994: [SPARK-30339][SQL] Avoid to fail twice in function lookup
Date Mon, 30 Dec 2019 09:05:58 GMT
HyukjinKwon commented on a change in pull request #26994: [SPARK-30339][SQL] Avoid to fail
twice in function lookup
URL: https://github.com/apache/spark/pull/26994#discussion_r361932169
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
 ##########
 @@ -117,12 +117,25 @@ private[sql] class HiveSessionCatalog(
     try {
       lookupFunction0(name, children)
     } catch {
-      case NonFatal(_) =>
 
 Review comment:
   That's fine. Let's just go simple. The original fix itself is a partial band-aid fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message