spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #27039: [SPARK-29174][SQL] LOCAL is not supported in INSERT OVERWRITE DIRECTORY to data source
Date Mon, 30 Dec 2019 07:53:26 GMT
HyukjinKwon commented on a change in pull request #27039: [SPARK-29174][SQL] LOCAL is not supported
in INSERT OVERWRITE DIRECTORY to data source
URL: https://github.com/apache/spark/pull/27039#discussion_r361918722
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
 ##########
 @@ -793,11 +793,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf) {
    */
   override def visitInsertOverwriteDir(
       ctx: InsertOverwriteDirContext): InsertDirParams = withOrigin(ctx) {
-    if (ctx.LOCAL != null) {
 
 Review comment:
   `insert into local directory overwrite /a/b/c <datasource>` will write into the local
file system regardless of default file system; however, `insert into directory overwrite /a/b/c
<datasource>` will write according to the default scheme (e.g., `fs.default.name`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message