spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] 07ARB commented on a change in pull request #26477: [SPARK-29776][SQL] rpad should return NULL when padstring parameter is empty
Date Thu, 26 Dec 2019 12:11:11 GMT
07ARB commented on a change in pull request #26477: [SPARK-29776][SQL] rpad should return NULL
when padstring parameter is empty
URL: https://github.com/apache/spark/pull/26477#discussion_r361442888
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/strings.sql
 ##########
 @@ -629,6 +629,7 @@ SELECT rpad('hi', 5);
 SELECT rpad('hi', -5, 'xy');
 SELECT rpad('hello', 2);
 SELECT rpad('hi', 5, '');
+-- PostgreSQL return: hi:  because not implemented as per the rpad behaviours(In case of
empty pad string, the return value is null)
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message