spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] yaooqinn commented on a change in pull request #26995: [SPARK-30341][SQL] Overflow check for interval arithmetic operations
Date Tue, 24 Dec 2019 07:50:26 GMT
yaooqinn commented on a change in pull request #26995: [SPARK-30341][SQL] Overflow check for
interval arithmetic operations
URL: https://github.com/apache/spark/pull/26995#discussion_r361093504
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
 ##########
 @@ -218,6 +252,11 @@ object BinaryArithmetic {
   """)
 case class Add(left: Expression, right: Expression) extends BinaryArithmetic {
 
+  override def nullable: Boolean = dataType match {
+    case CalendarIntervalType if !checkOverflow => true
 
 Review comment:
   Yes, we have.
   we now have `+/-/unaray_-` in java overflow behavior(2.4 or maybe earlier)
   and we have '*/-' in null for overflow behavior (3.0)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message