spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] viirya commented on a change in pull request #26977: [SPARK-30326][SQL] Raise exception if analyzer exceed max iterations
Date Sun, 22 Dec 2019 23:59:45 GMT
viirya commented on a change in pull request #26977: [SPARK-30326][SQL] Raise exception if
analyzer exceed max iterations
URL: https://github.com/apache/spark/pull/26977#discussion_r360737052
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -169,7 +169,7 @@ class Analyzer(
 
   def resolver: Resolver = conf.resolver
 
-  protected val fixedPoint = FixedPoint(maxIterations)
+  protected val fixedPoint = FixedPoint(maxIterations, errorOnExceed = true)
 
 Review comment:
   > Analyzer should raise exception to indicates logical plan resolve failed, while optimizer
just log warning to keep the current plan. 
   
   Does exceeding max iteration indicate analyzer fails logical plan resolving? Doesn't it
just mean the plan is not fixed after max iterations? It sounds not equal.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message