spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] dongjoon-hyun commented on a change in pull request #26854: [SPARK-30040][SQL] DROP FUNCTION should do multi-catalog resolution
Date Thu, 12 Dec 2019 17:13:27 GMT
dongjoon-hyun commented on a change in pull request #26854: [SPARK-30040][SQL] DROP FUNCTION
should do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26854#discussion_r357266986
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -3392,4 +3391,20 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef]
with Logging
     val functionName = Option(ctx.multipartIdentifier).map(visitMultipartIdentifier)
     ShowFunctionsStatement(userScope, systemScope, pattern, functionName)
   }
+
+  /**
+   * Create a [[DropFunctionCommand]] statement.
 
 Review comment:
   `DropFunctionCommand` -> `DropFunctionStatement`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message