spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #26809: [SPARK-30185][SQL] Implement Dataset.tail API
Date Tue, 10 Dec 2019 00:41:37 GMT
HyukjinKwon commented on a change in pull request #26809: [SPARK-30185][SQL] Implement Dataset.tail
API
URL: https://github.com/apache/spark/pull/26809#discussion_r355775511
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ##########
 @@ -810,6 +810,26 @@ case class LocalLimit(limitExpr: Expression, child: LogicalPlan) extends
OrderPr
   }
 }
 
+/**
+ * This is similar with [[Limit]] except,
+ *
+ * - It does not have plans for global/local separately because currently there is only one
+ *   implementation which does both global/local tails. See
 
 Review comment:
   Let me try to reword it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message