spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] maropu commented on a change in pull request #26699: [SPARK-30066][SQL] Columnar execution support for interval types
Date Mon, 09 Dec 2019 02:37:12 GMT
maropu commented on a change in pull request #26699: [SPARK-30066][SQL] Columnar execution
support for interval types
URL: https://github.com/apache/spark/pull/26699#discussion_r355239937
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala
 ##########
 @@ -705,6 +705,35 @@ private[columnar] case class MAP(dataType: MapType)
   override def clone(v: UnsafeMapData): UnsafeMapData = v.copy()
 }
 
+private[columnar] object CALENDAR_INTERVAL extends ColumnType[CalendarInterval]
+  with DirectCopyColumnType[CalendarInterval]{
 
 Review comment:
   nit: `]{` -> `] {`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message