spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] tdas commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping a streaming query
Date Fri, 06 Dec 2019 03:00:12 GMT
tdas commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping
a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r354647095
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala
 ##########
 @@ -142,8 +143,13 @@ trait StreamingQuery {
   def processAllAvailable(): Unit
 
   /**
-   * Stops the execution of this query if it is running. This method blocks until the threads
-   * performing execution has stopped.
+   * Stops the execution of this query if it is running. This awaits the termination of the
query
+   * execution threads or until the `spark.sql.streaming.stopTimeout` is hit. A timeout of
0
+   * milliseconds will block indefinitely.
+   *
+   * @throws TimeoutException If the thread cannot be stopped within the timeout
 
 Review comment:
   If the timeout is configured to be a positive value, then this exception is thrown ....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message