spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error messages for unsupported data type
Date Mon, 02 Dec 2019 09:00:38 GMT
HyukjinKwon commented on a change in pull request #26577: [SPARK-29943][SQL] Improve error
messages for unsupported data type
URL: https://github.com/apache/spark/pull/26577#discussion_r352478177
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -982,7 +988,8 @@ private[hive] object HiveClientImpl {
       CatalystSqlParser.parseDataType(hc.getType)
     } catch {
       case e: ParseException =>
-        throw new SparkException("Cannot recognize hive type string: " + hc.getType, e)
+        throw new SparkException(s"Cannot recognize hive type string: ${hc.getType}," +
+          s"column: ${hc.getName}", e)
 
 Review comment:
   ```scala
           throw new SparkException(
             s"Cannot recognize hive type string: ${hc.getType}, column: ${hc.getName}", e)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message