spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] xy2953396112 commented on a change in pull request #26693: [MINOR][SS] Note that writer should not be closed in RateStreamMicroBatchStream.serialize
Date Mon, 02 Dec 2019 03:10:09 GMT
xy2953396112 commented on a change in pull request #26693: [MINOR][SS] Note that writer should
not be closed in RateStreamMicroBatchStream.serialize
URL: https://github.com/apache/spark/pull/26693#discussion_r352405272
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchStream.scala
 ##########
 @@ -62,6 +62,7 @@ class RateStreamMicroBatchStream(
 
     val metadataLog =
       new HDFSMetadataLog[LongOffset](session.get, checkpointLocation) {
+        // Writer should not close the given stream when overriding methods.
 
 Review comment:
   my mistake... Please review again.Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message