From reviews-return-974971-archive-asf-public=cust-asf.ponee.io@spark.apache.org Fri Nov 22 08:16:00 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A02D180629 for ; Fri, 22 Nov 2019 09:15:59 +0100 (CET) Received: (qmail 71856 invoked by uid 500); 22 Nov 2019 08:15:59 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 71844 invoked by uid 99); 22 Nov 2019 08:15:59 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Nov 2019 08:15:59 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] imback82 edited a comment on issue #26617: [SPARK-29979][SQL]Add basic/reserved property key constants in Table and SupportsNamespaces Message-ID: <157441055919.7804.3861992489638415087.gitbox@gitbox.apache.org> Date: Fri, 22 Nov 2019 08:15:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit imback82 edited a comment on issue #26617: [SPARK-29979][SQL]Add basic/reserved property key constants in Table and SupportsNamespaces URL: https://github.com/apache/spark/pull/26617#issuecomment-557435703 > These special properties have specific meanings, and the data source developers should be aware of them. It's better to put them in the DS v2 API, with comments to explain what they are. +1, I like this idea. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org