From reviews-return-973687-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Nov 21 06:35:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B3B62180660 for ; Thu, 21 Nov 2019 07:35:22 +0100 (CET) Received: (qmail 59470 invoked by uid 500); 21 Nov 2019 06:35:22 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 59455 invoked by uid 99); 21 Nov 2019 06:35:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2019 06:35:22 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #26611: [SPARK-29939][CORE] Add a conf for CompressionCodec for Ser/Deser of MapOutputStatus Message-ID: <157431812198.15263.1296922345762299087.gitbox@gitbox.apache.org> Date: Thu, 21 Nov 2019 06:35:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #26611: [SPARK-29939][CORE] Add a conf for CompressionCodec for Ser/Deser of MapOutputStatus URL: https://github.com/apache/spark/pull/26611#discussion_r348915101 ########## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ########## @@ -1016,6 +1016,15 @@ package object config { .booleanConf .createWithDefault(true) + private[spark] val MAP_STATUS_COMPRESSION_CODEC = + ConfigBuilder("spark.shuffle.mapStatus.compression.codec") + .doc("The codec used to compress MapStatus, which is generated by ShuffleMapTask. " + + "By default, Spark provides four codecs: lz4, lzf, snappy, and zstd. You can also " + + "use fully qualified class names to specify the codec. If this is not given, " + + "spark.io.compression.codec will be used.") Review comment: we can remove this sentence if we don't fallback to spark.io.compression.codec ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org