From reviews-return-973467-archive-asf-public=cust-asf.ponee.io@spark.apache.org Thu Nov 21 03:20:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EB4D51804BB for ; Thu, 21 Nov 2019 04:20:26 +0100 (CET) Received: (qmail 31771 invoked by uid 500); 21 Nov 2019 03:20:26 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 31746 invoked by uid 99); 21 Nov 2019 03:20:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2019 03:20:25 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] Deegue removed a comment on issue #26541: [SPARK-29910][SQL] Optimize speculation performance by adding minimum runtime limit Message-ID: <157430642547.5513.12748438527711320254.gitbox@gitbox.apache.org> Date: Thu, 21 Nov 2019 03:20:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Deegue removed a comment on issue #26541: [SPARK-29910][SQL] Optimize speculation performance by adding minimum runtime limit URL: https://github.com/apache/spark/pull/26541#issuecomment-556901420 Thanks for your review @cloud-fan . Before this patch, the minimum runtime is set to 100ms which means almost all the tasks meet the condition will be speculated. After this patch and setting it to 60s, a lot of tasks finished in seconds won't be speculated and our cluster is in better performance. Thus I think it's useful in this case. As for jobs and stages, `spark.speculation.quantile` and `spark.speculation.multiplier` will help to judge which task need to be speculated in different situations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org