From reviews-return-971070-archive-asf-public=cust-asf.ponee.io@spark.apache.org Tue Nov 19 00:25:41 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 79155180657 for ; Tue, 19 Nov 2019 01:25:41 +0100 (CET) Received: (qmail 58190 invoked by uid 500); 19 Nov 2019 00:25:40 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 58136 invoked by uid 99); 19 Nov 2019 00:25:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 00:25:40 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] HeartSaVioR commented on issue #23782: [SPARK-26875][SS] Add an option on FileStreamSource to include modified files Message-ID: <157412314069.8510.9972344875806486509.gitbox@gitbox.apache.org> Date: Tue, 19 Nov 2019 00:25:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit HeartSaVioR commented on issue #23782: [SPARK-26875][SS] Add an option on FileStreamSource to include modified files URL: https://github.com/apache/spark/pull/23782#issuecomment-555273404 > File lastest_sales.csv gets deleted (manually or via the new configuration #22952) I don't think it is safe to delete the file manually outside of Spark, as it cannot be known whether the file is processed and added to the commit log. Checking whether the file is processed is not sufficient - it should ensure the file will be never accessed. Assuming the file is deleted/archived from Spark, I'm seeing the possible confusion from user side as well since it's no longer an "overwrite" if the file is processed and cleaned up. So that seems to be a valid use case, though we may need to think how we let Spark differentiate "overwrite" and "add new file which was deleted or moved". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org