From reviews-return-965302-archive-asf-public=cust-asf.ponee.io@spark.apache.org Wed Nov 13 11:26:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 94D9D180621 for ; Wed, 13 Nov 2019 12:26:26 +0100 (CET) Received: (qmail 42680 invoked by uid 500); 13 Nov 2019 11:26:26 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 42664 invoked by uid 99); 13 Nov 2019 11:26:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Nov 2019 11:26:25 +0000 From: GitBox To: reviews@spark.apache.org Subject: [GitHub] [spark] cloud-fan commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite Message-ID: <157364438584.30114.3211166551094421306.gitbox@gitbox.apache.org> Date: Wed, 13 Nov 2019 11:26:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cloud-fan commented on a change in pull request #26497: [SPARK-29873][SQL][TESTS] Support `--import` directive to load queries from another test case in SQLQueryTestSuite URL: https://github.com/apache/spark/pull/26497#discussion_r345706071 ########## File path: sql/core/src/test/resources/sql-tests/inputs/ansi/decimalArithmeticOperations.sql ########## @@ -0,0 +1,2 @@ +-- throw an exception instead of returning NULL, according to SQL ANSI 2011 Review comment: can we add a little more description? when will we throw an exception? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org