spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
Date Sat, 30 Nov 2019 08:29:16 GMT
amanomer commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages
when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r352273368
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -118,7 +118,7 @@ class SimpleFunctionRegistry extends FunctionRegistry with Logging {
         throw new AnalysisException(s"undefined function $name")
       }
     }
-    func(children)
+    func(children).setFuncName(name.funcName)
 
 Review comment:
   `every` here does not have any node. It will be resolved as a `BoolAnd`.
   https://github.com/apache/spark/blob/32af7004a254107340df908e8dd91a0bc22e068e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L316-L320

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message