spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages when function name is an alias
Date Fri, 29 Nov 2019 14:06:08 GMT
srowen commented on a change in pull request #26712: [SPARK-29883][SQL] Improve error messages
when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r352146629
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -118,7 +118,7 @@ class SimpleFunctionRegistry extends FunctionRegistry with Logging {
         throw new AnalysisException(s"undefined function $name")
       }
     }
-    func(children)
+    func(children).setFuncName(name.funcName)
 
 Review comment:
   Hm, do functions not already have names somewhere to use, that can already be set differently
per alias? it looks like that's what nodeName is for, and it's already overridden in the aliases,
so I'm missing why this is different.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message