spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] HyukjinKwon commented on a change in pull request #26710: [SPARK-29991][INFRA] Support Hive 1.3 and Hive 2.3 (default) in PR builder
Date Fri, 29 Nov 2019 08:29:43 GMT
HyukjinKwon commented on a change in pull request #26710: [SPARK-29991][INFRA] Support Hive
1.3 and Hive 2.3 (default) in PR builder
URL: https://github.com/apache/spark/pull/26710#discussion_r352022743
 
 

 ##########
 File path: dev/run-tests-jenkins.py
 ##########
 @@ -182,6 +182,11 @@ def main():
         os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7"
     if "test-hadoop3.2" in ghprb_pull_title:
         os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop3.2"
+    # Switch the Hive profile based on the PR title:
+    if "test-hive1.2" in ghprb_pull_title:
+        os.environ["AMPLAB_JENKINS_BUILD_HIVE_PROFILE"] = "hive1.2"
+    if "test-hive2.3" in ghprb_pull_title:
+        os.environ["AMPLAB_JENKINS_BUILD_HIVE_PROFILE"] = "hive2.3"
 
 Review comment:
   cc @shaneknapp, maybe we can use it this environment variable (?) later when we consider
setting the Jenkins jobs for Hive 1.2/2.3 + Hadoop 2.7/3.2 + JDK 8/11 combinations.
   
   The env name looks a bit odd given `AMPLAB_JENKINS_BUILD_PROFILE`. We might have to rename
it later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message