spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] gatorsmile commented on a change in pull request #26320: [SPARK-29654][CORE] Add configuration to allow disabling registration of static sources to the metrics system
Date Wed, 27 Nov 2019 07:33:02 GMT
gatorsmile commented on a change in pull request #26320: [SPARK-29654][CORE] Add configuration
to allow disabling registration of static sources to the metrics system
URL: https://github.com/apache/spark/pull/26320#discussion_r351129393
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -615,6 +615,12 @@ package object config {
     .stringConf
     .createOptional
 
+  private[spark] val METRICS_STATIC_SOURCES_ENABLED =
+    ConfigBuilder("spark.metrics.static.sources.enabled")
 
 Review comment:
   `spark.metrics.staticSources.enabled` might look better. Using static as the name space
looks weird. cc @cloud-fan @Ngone51 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message