spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] imback82 commented on a change in pull request #26667: [SPARK-29922][SQL] SHOW FUNCTIONS should do multi-catalog resolution
Date Wed, 27 Nov 2019 00:32:21 GMT
imback82 commented on a change in pull request #26667: [SPARK-29922][SQL] SHOW FUNCTIONS should
do multi-catalog resolution
URL: https://github.com/apache/spark/pull/26667#discussion_r351045352
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
 ##########
 @@ -455,6 +455,25 @@ class ResolveSessionCatalog(
       ShowTablePropertiesCommand(
         tableName.asTableIdentifier,
         propertyKey)
+
+    case ShowFunctionsStatement(scope, pattern, functionName) =>
+      import ShowFunctionsStatement._
+      val userScope = scope.map(s => s == ALL || s == USER).getOrElse(true)
+      val systemScope = scope.map(s => s == ALL || s == SYSTEM).getOrElse(true)
+      val (db, function) = functionName match {
 
 Review comment:
   Looks like this is not addressed as suggested by @cloud-fan?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message