spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] yaooqinn commented on a change in pull request #26681: [SPARK-30048][SQL] Enable aggregates with interval type values for RelationalGroupedDataset
Date Tue, 26 Nov 2019 14:02:26 GMT
yaooqinn commented on a change in pull request #26681: [SPARK-30048][SQL] Enable aggregates
with interval type values for RelationalGroupedDataset
URL: https://github.com/apache/spark/pull/26681#discussion_r350758151
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala
 ##########
 @@ -98,10 +98,10 @@ class RelationalGroupedDataset protected[sql](
       // Make sure all specified columns are numeric.
       colNames.map { colName =>
         val namedExpr = df.resolve(colName)
-        if (!namedExpr.dataType.isInstanceOf[NumericType]) {
+        if (!TypeCollection.NumericAndInterval.acceptsType(namedExpr.dataType)) {
 
 Review comment:
   thanks for your suggestion. Please check 。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message