spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] srowen commented on a change in pull request #26626: [SPARK-29986][SQL] Introduce java like string trim to UTF8String
Date Thu, 21 Nov 2019 12:56:41 GMT
srowen commented on a change in pull request #26626: [SPARK-29986][SQL] Introduce java like
string trim to UTF8String
URL: https://github.com/apache/spark/pull/26626#discussion_r349067210
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
 ##########
 @@ -553,6 +553,29 @@ public UTF8String trim() {
     return copyUTF8String(s, e);
   }
 
+  /**
+   * Trims whitespaces (<= ASCII 32) from both ends of this string.
 
 Review comment:
   Interesting, so SQL trim just removes space, and java.lang.String.trim() removes everything
<= 32. Maybe we could refer to that in this doc, that this is the purpose of this additional
trim method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message