spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [spark] yaooqinn commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim
Date Thu, 21 Nov 2019 09:01:06 GMT
yaooqinn commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String
Trim
URL: https://github.com/apache/spark/pull/26622#discussion_r348961970
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
 ##########
 @@ -1077,6 +1090,7 @@ public UTF8String translate(Map<Character, Character> dict) {
    * @return true if the parsing was successful else false
    */
   public boolean toLong(LongWrapper toLongResult) {
 
 Review comment:
   Do you mean copy this insideTrim logic here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message